Enable resolving languages without CodeQL CLI #3116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow checks that src/resolved-languages.json exists and is up-to-date with respect to the default (linked) CodeQL version.
This commit fixes the BetterResolveLanguagesOutput interface, which
currently defines the `extractors` map values as tuples:
[ { extractor_root: string; ... }, ]
Instead of arrays (which are what the CodeQL CLI produces):
Array<{ extractor_root: string; ... }>
cklin
force-pushed
the
cklin/languages-without-cli
branch
from
d2d866e to
376055c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to resolve supported languages without requiring the CodeQL CLI to be available. It introduces getStoredSupportedLanguageMap() function and refactors the existing language resolution logic to support both CLI-based and stored language maps.
Key changes:
- Added a stored language map functionality using a static JSON file
- Refactored
getLanguages()to accept a pre-computed language map instead of generating it internally - Added validation workflow to ensure the stored language data stays current
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/resolved-languages.json | New static file containing pre-resolved language and extractor information |
| src/config-utils.ts | Added getStoredSupportedLanguageMap(), refactored getLanguages() signature, and extracted buildSupportedLanguageMap() helper |
| src/config-utils.test.ts | Updated test calls to match new getLanguages() signature |
| src/codeql.ts | Updated BetterResolveLanguagesOutput interface to use consistent array type |
| lib/init-action.js | Generated JavaScript reflecting the TypeScript changes |
| .github/workflows/validate-resolved-languages.yml | New workflow to validate the stored language file stays current |
| OverlayDatabaseMode, | ||
| } from "./overlay-database-utils"; | ||
| import { RepositoryNwo } from "./repository"; | ||
| import * as resolvedLanguages from "./resolved-languages.json"; |
There was a problem hiding this comment.
The import statement assumes the JSON file will always be valid. Consider adding runtime validation to ensure the imported data conforms to the expected BetterResolveLanguagesOutput structure, or handling potential parsing errors gracefully.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
getStoredSupportedLanguageMap()and refactorsgetLanguages()so that theinitaction can get the list of supported languages (along with their aliases) even when the CodeQL CLI is unavailable.getStoredSupportedLanguageMap()is currently unused. It will be used in a future PR.Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist