put a limit on the length of the equivalent range in overly-large-range #10213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Let's merge this into the 3.7 branch. |
tausbn
approved these changes
Aug 29, 2022
| @@ -238,8 +238,13 @@ module RangePrinter { | |||
|
|
|||
| /** Gets a char range that is overly large because of `reason`. */ | |||
| RegExpCharacterRange getABadRange(string reason, int priority) { | |||
| result instanceof OverlyWideRange and | |||
There was a problem hiding this comment.
I'm surprised that this instanceof check is needed. Isn't this implied by the inline cast on line 243? 🤔
There was a problem hiding this comment.
You're right, that check is not needed, but I'm going this merge this PR as is anyway.
The cast was needed in one of the first versions of my fix, but it's not needed with the version I ended up with.
Maybe a QL-for-QL query in the style of ql/superfluous-exists?
|
The JavaScript language tests are failing, that is unrelated and will be fixed here: #9751 I'm merging this PR now, and I'll cherry-pick the commit to a new PR against the 3.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overly-large-range query would produce an extremely big alert message on some regexps from
natalie-lang/natalie.This fixes it.
I capped the range at 50 chars, because that broke no tests in the existing test-suite.