Skip to content

Ruby: do not depend on trackDefNode in isDef #12703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

Ruby: do not depend on trackDefNode in isDef #12703

merged 1 commit into from
Mar 31, 2023

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Mar 29, 2023

Ensure isDef/isUse can be computed as an SCC before the trackUseNode/trackDefNode SCC.

Evaluation doesn't show much of a difference.

@asgerf asgerf added no-change-note-required This PR does not need a change note Ruby labels Mar 29, 2023
@asgerf asgerf requested a review from a team as a code owner March 29, 2023 11:02
hvitved
hvitved approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if defCand is lacking a not mid instanceof DataFlowPrivate::SelfParameterNode check, similar to trackDefNode (not related to your change).

@asgerf
Copy link
Contributor Author

asgerf commented Mar 31, 2023

That is a good question, I'll take a look separately from this PR

@asgerf asgerf merged commit 008ffea into github:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asgerf @hvitved