Python: allow tests to require relative paths #14844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoff
force-pushed
the
python/tests-ignore-stdlib
branch
from
0944612 to
3719b92
Compare
RasmusWL
requested changes
Nov 21, 2023
There was a problem hiding this comment.
From my point of view we should actually ensure that we don't generate alerts we don't want, like you did in 421d4f3, so I don't agree with the premise of this PR.
I think we should close it instead. (since we're actively working on not extracting stdlib anyway, this problem should go away soon as well)
Ok, I am happy to with this approach 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors our test utility slightly to provide a new transformer
IgnoreAbsolutePaths. This changes a dataflow test configuration such that sinks require the existence of a relative path. The name may need work. Also, do we want this or do we want all test to already have this property by construction somehow?The PR also currently applies this transformer to the path injection dataflow test, inspired by #14777, which may be unnecessary and/or inappropriate if that PR is accepted.