Skip to content

Ruby: add docs for customizing library models with data extensions #15488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2024
Merged

Ruby: add docs for customizing library models with data extensions #15488

merged 3 commits into from
Feb 15, 2024

Conversation

hmac
Copy link
Contributor

@hmac hmac commented Jan 31, 2024 •
edited
Loading

Add documentation on customizing Ruby analysis using data extensions. This closely follows the format of the JS documentation.

@hmac hmac marked this pull request as ready for review February 5, 2024 11:40
@hmac hmac added the Ruby label Feb 5, 2024
@sidshank sidshank requested a review from subatoi February 6, 2024 01:05
@sidshank sidshank added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Feb 6, 2024
subatoi
subatoi previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best I can tell this looks great from a Docs perspective, thanks—I had a few comments but I don't know if they're all accurate as I'm not an SME, so feel free to ignore as appropriate.

@github-actions github-actions bot removed the Ruby label Feb 12, 2024
@hmac
Copy link
Contributor Author

hmac commented Feb 12, 2024

@subatoi thank you for the thorough review! Agree with everything you've said, and I've fixed up those cases.

subatoi
subatoi approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hmac! This looks good to me so consider it approved from the Docs side 👍

@hmac hmac requested a review from a team February 12, 2024 13:16
@sidshank
Copy link
Contributor

@alexrford and @asgerf - I've assigned this PR to you, given your involvement in library modelling and automation efforts, and writing similar documentation for JavaScript (respectively).

asgerf
asgerf approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 👍

@hmac hmac merged commit babae65 into github:main Feb 15, 2024
@hmac hmac deleted the ruby-mad-docs branch February 15, 2024 07:58
@hmac hmac mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf asgerf approved these changes

@subatoi subatoi subatoi approved these changes

Assignees

@asgerf asgerf

@alexrford alexrford

Labels
documentation ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hmac @sidshank @asgerf @subatoi @alexrford