Ssa: Deprecate the unused getALastRead predicate. #18729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
There was a problem hiding this comment.
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
github-actions
bot
added
C#
JS
C++
Ruby
Rust
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -292,7 +290,9 @@ | |||
|
|
|||
| /** Same as `lastRefRedef`, but skips uncertain reads. */ | |||
| pragma[nomagic] | |||
| private predicate lastRefSkipUncertainReadsExt(DefinitionExt def, SsaInput::BasicBlock bb, int i) { | |||
| deprecated private predicate lastRefSkipUncertainReadsExt( | |||
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
reviewed
Feb 10, 2025
| @@ -958,7 +960,7 @@ private module Cached { | |||
| } | |||
|
|
|||
| cached | |||
There was a problem hiding this comment.
I think it's OK to replace this with pragma[nomagic]; I highly doubt anyone actually calls this.
| @@ -407,7 +409,7 @@ private module Cached { | |||
| * the end of the CFG scope, without passing through another non-pseudo read. | |||
| */ | |||
| cached | |||
| predicate lastRead(Definition def, VariableReadAccessCfgNode read) { | |||
| deprecated predicate lastRead(Definition def, VariableReadAccessCfgNode read) { | |||
hvitved
approved these changes
Feb 10, 2025
erik-krogh
approved these changes
Feb 10, 2025
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSA predicate
getALastReadis entirely unused. Presumably this was needed in the past for proper implementation ofoutandrefnodes in C#, but this is now handled via pseudo-reads.This PR deprecates all involved predicates (or deletes in the case of Rust). This means that the
ExitBasicBlockin theInputSigis effectively unused, so a second commit deletes that.