Ruby: mass enable diff-informed data flow none() location overrides
#19798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An auto-generated patch that enables diff-informed data flow in the obvious cases.
Adds `getASelected{Source,Sink}Location() { none() }` override to queries that select a dataflow source or sink as a location, but not both.
There was a problem hiding this comment.
Pull Request Overview
Enables diff-informed incremental data flow by overriding the selected-source location to none() in configs that only select a dataflow source.
- Implement
getASelectedSourceLocation(DataFlow::Node)override in BasicTaintConfig - Implement the same override in WeakParamsConfig
- Implement the same override in HttpVerbConfig
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ruby/ql/src/queries/meta/TaintedNodes.ql | Added getASelectedSourceLocation override in BasicTaintConfig |
| ruby/ql/src/experimental/weak-params/WeakParams.ql | Added getASelectedSourceLocation override in WeakParamsConfig |
| ruby/ql/src/experimental/manually-check-http-verb/ManuallyCheckHttpVerb.ql | Added getASelectedSourceLocation override in HttpVerbConfig |
Comments suppressed due to low confidence (2)
ruby/ql/src/queries/meta/TaintedNodes.ql:25
- [nitpick] Add a brief comment explaining why
getASelectedSourceLocationis overridden tonone()in diff-informed incremental mode, to aid future maintainers.
Location getASelectedSourceLocation(DataFlow::Node source) { none() }
ruby/ql/src/queries/meta/TaintedNodes.ql:25
- No existing tests cover the new override behavior in diff-informed incremental mode; consider adding a unit test to verify that
getASelectedSourceLocationreturnsnone()as expected.
Location getASelectedSourceLocation(DataFlow::Node source) { none() }
Comment on lines
+24
to
27
|
|
||
| Location getASelectedSourceLocation(DataFlow::Node source) { none() } | ||
| } | ||
|
|
There was a problem hiding this comment.
[nitpick] This override is duplicated across multiple config modules; consider extracting it into a shared mixin or trait to reduce repetition.
Suggested change
| Location getASelectedSourceLocation(DataFlow::Node source) { none() } | |
| } | |
| private module SharedTaintConfig { | |
| Location getASelectedSourceLocation(DataFlow::Node source) { none() } | |
| } | |
| private module BasicTaintConfig implements DataFlow::ConfigSig, SharedTaintConfig { | |
| } |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An auto-generated patch that enables diff-informed data flow in the obvious cases.
Adds
getASelected{Source,Sink}Location() { none() }override to queries that select a dataflow source or sink as a location, but not both.