Skip to content

C++: More QLDoc #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 25, 2020
Merged

C++: More QLDoc #3783

merged 7 commits into from
Jun 25, 2020

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Jun 24, 2020

Add more QLDoc in various places. Deprecate Member.qll and some overly specific stuff in Type.qll (none of these things are meaningfully used as far as I can tell).

@geoffw0 geoffw0 added the C++ label Jun 24, 2020
@geoffw0 geoffw0 requested a review from a team as a code owner June 24, 2020 13:02
rdmarsh2
rdmarsh2 previously approved these changes Jun 24, 2020
Copy link
Contributor

@rdmarsh2 rdmarsh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a format check failing for NestedFields.qll, LGTM otherwise.

Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for spelling nits.

Co-authored-by: Jonas Jensen <[email protected]>
@geoffw0
Copy link
Contributor Author

geoffw0 commented Jun 25, 2020

Fixed issues.

@jbj jbj merged commit f2ef088 into github:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants