Python: dataflow, bypass ssa nodes #4657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend `DefinitionNode` to handle `With`
An `EssaNodeDefinition` may not have flow into it from a `ControlFlowNode`. This happens for instance with iterator variables in for loops. Simply bypassing the `EssaVariable` therefor drops the flow. Adding the defining node in-between restores it.
|
Closed in favour of #14777. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ultimate goal of this work is to remove SSA nodes from the data-flow graph. This should simplify our data-flow graph, but also simplify tasks such as solving variable capture. Unfortunately, it may in fact be necessary to solve variable capture first, as this is partly handled by SSA nodes and scope-entry definitions.