CPP: Deprecate MacroInvocationExpr and MacroInvocationStmt #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj
reviewed
Jan 10, 2019
|
I've created https://git.semmle.com/Semmle/code/pull/30211 to address the tests. Once that's merged I'll rebase this and/or add a submodule update, which should resolve the test failures. |
|
I've merged the internal PR, and I think that should be enough to make Language-Tests/CPP pass without any further work. I'll re-trigger them. |
jbj
approved these changes
Jan 25, 2019
cklin
pushed a commit
that referenced
this pull request
May 20, 2022
Release preparation for version 2.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukecartey has said that the
MacroInvocationExprclass is confusing and commonly misunderstood by new [and if we're honest, not so new] QL authors. I tend to agree, and I further believe that when used correctly, it often just adds a layer of obfuscation over usingMacroInvocation.getExpr()directly. I have deprecated it and replaced it's usage in our libraries.MacroInvocationStmtwas not used but suffers the same problems in principle. Also deprecated.I've also added test cases for
ArithmeticUncontrolled.ql. The use (isRandValue) inArithmeticUncontrolled.qlis really quite dubious and should be replaced with cleaner logic that's able to handle the same cases at some point.