JavaScript: Assign FileAccessToHttp and HttpToFileAccess a precision.
#908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. They will now be run on LGTM, but their results won't be displayed by default.
ghost
approved these changes
Feb 8, 2019
|
Yeah, me too. Probably due to missing API modelling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They will now be run on LGTM, but their results won't be displayed by default.
An evaluation (internal link) suggests that their performance is roughly what you'd expect from inter-procedural queries, and at least on our default projects the number of results is manageable. Still, they aren't results we'd want to show by default, hence precision
medium.After the next dist upgrade I plan to look over a few more results on lgtm.com and then decide what to do about these queries.