Skip to content

Conversation

aschackmull
Copy link
Contributor

useFieldFlow is unary and should therefore not use unbind as that just causes a cartesian product, and joining directly on the config is fine as it won't introduce other fields.

@aschackmull aschackmull added C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR labels Aug 24, 2018
@ghost
Copy link

ghost commented Aug 24, 2018

CLA assistant check
All committers have signed the CLA.

@aschackmull aschackmull requested a review from jbj August 24, 2018 08:43
jbj
jbj previously approved these changes Aug 24, 2018
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aschackmull
Copy link
Contributor Author

Rebased.

@jbj jbj merged commit f88dc37 into github:master Aug 28, 2018
@aschackmull aschackmull deleted the java/fieldflow-perf branch August 28, 2018 13:42
aibaars pushed a commit that referenced this pull request Oct 14, 2021
CFG: Use manual `toString()`s for `AstCfgNode` when available
smowton pushed a commit to smowton/codeql that referenced this pull request Dec 6, 2021
Change build script to build multiple versions of the plugin
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
dbartol pushed a commit that referenced this pull request Dec 18, 2024
Improve Bash script parser
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants