Skip to content

Conversation

stephenotalora
Copy link
Contributor

The import/named rule from ESLint Core will report on lines that don't violate the rule when run on TypeScript files. We should probably do something similar to our no-shadow fix

References

#127

@koddsson
Copy link
Contributor

Is there a rule called import/named in @typescript-eslint? I couldn't find it in the repository.

@stephenotalora
Copy link
Contributor Author

stephenotalora commented Jul 16, 2021

Is there a rule called import/named in @typescript-eslint? I couldn't find it in the repository.

good catch, this only silences the error. it looks like we needed another plugin for the typescript parser to properly work with named imports. Extending from 'plugin:import/typescript' fixes this problem.

No PR needed here closing in favor of https://github.com/benmosher/eslint-plugin-import/blob/master/README.md#typescript

@stephenotalora stephenotalora deleted the import-named-fix branch July 16, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants