Skip to content

Remove scripts #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2020
Merged

Remove scripts #99

merged 4 commits into from
Mar 23, 2020

Conversation

koddsson
Copy link
Contributor

Remove the custom scripts we got from the package. Additionally update the docs with correct info on how to configure and use this package.

This part has been split out from #90 to be more reviewable.

This is a breaking change and will be published as major version 4 once everything from #90 has been merged into master.

@koddsson koddsson added this to the 4.0.0 milestone Mar 19, 2020
@koddsson koddsson requested a review from a team March 19, 2020 16:57
keithamus
keithamus approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big 👍

@koddsson koddsson merged commit ccd340b into master Mar 23, 2020
@koddsson koddsson deleted the remove-scripts branch March 23, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@keithamus keithamus keithamus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@koddsson @keithamus