Skip to content

rest2html: treat referenced wrapped images in base document as inlined #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

rest2html: treat referenced wrapped images in base document as inlined #1935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/github/commands/rest2html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,12 @@ class GitHubHTMLTranslator(HTMLTranslator):
self.body.append(self.starttag(node, 'img', **atts))
HTMLTranslator.depart_image(self, node)

# treat images held in a reference on the base document as inlined
# images; this is to help avoid rendering a reference's decorative
# line for the spacing after an image
if (isinstance(node.parent, nodes.reference)
and isinstance(node.parent.parent, nodes.document)):
self.body.append(self.body.pop().rstrip('\n'))

def kbd(name, rawtext, text, lineno, inliner, options={}, content=[]):
return [nodes.raw('', '<kbd>%s</kbd>' % text, format='html')], []
Expand Down