This repository was archived by the owner on May 5, 2020. It is now read-only.
Convert DateTime to Time before quoting #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTime
does not respond togetlocal
, so the current quoting is wrong for DateTimes when the database is in local time: https://github.com/github/rails/blob/3-0-github/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb#L65-66cc @github/timezones @github/rails3