This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Use source-repository-package to pin Git deps in cabal. #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2019 18:59
Right now our CI build cycle time is ~20 minutes, mostly because we're rebuilding our vendored packages every time. This should help, at least to some degree, with that.
robrix
suggested changes
Jun 5, 2019
| @@ -29,7 +29,7 @@ before_install: | |||
|
|
|||
| install: | |||
| - cabal new-update | |||
| - cabal new-configure --enable-tests --write-ghc-environment-files=always | |||
There was a problem hiding this comment.
I think we’re going to want the .ghc.environment files generated for the doctests to work reliably, tho this may be more of a problem for matrix builds (IIRC).
| source-repository-package | ||
| type: git | ||
| location: https://github.com/rewinfrey/hspec-expectations-pretty-diff | ||
| tag: 94af5871c24ba319f7f72fefa53c1a4d074c9a29 |
added 2 commits
June 5, 2019 09:13
robrix
approved these changes
Jun 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now our CI build cycle time is ~20 minutes, mostly because we're
rebuilding our vendored packages every time. This should help, at
least to some degree, with that. We still have to vendor haskell-tree-sitter
manually until haskell/cabal#5536 is fixed.