Skip to content

Conversation

rmallorybpc
Copy link
Collaborator

@a-a-ron here are my proposed changes to the README file. I changed the order of the content, changed the module bullet lists to a comma list and indented the moduels under the learning path, added a brief summary from the MS Learn for GitHub page, and shortened the writing in the feedback statement. FYI @camihmerhar

@a-a-ron here are my proposed changes to the README file. I changed the order of the content, changed the module bullet lists to a comma list and indented the moduels under the learning path, added a brief summary from the MS Learn for GitHub page, and shortened the writing in the feedback statement. FYI @camihmerhar
@rmallorybpc rmallorybpc requested a review from a-a-ron October 26, 2022 18:07
@a-a-ron
Copy link
Collaborator

a-a-ron commented Oct 26, 2022

Thanks @rmallorybpc for putting some thought into this. I have a couple thoughts;

  • I like the condensed look for the learning paths/modules but I find it hard to see the modules in a comma list. I prefer to see the modules in a bulleted list but I'm open to be convinced otherwise. Perhaps we take a hybrid approach. What are your thoughts on keeping the bulleted list format but putting them into a dropdown per learning path?

  • I think we're missing a helpful resources section. A place to include the author pack link and slack channels to communicate with us.

  • I like the improved introduction under the image but I feel like we need an explanation on the purpose of this repo. If you're not familiar with the authoring process, it can give the impression that this repo builds the landing page on MS Learn. I think we should make it clear that this repo is to maintain the content we publish on MS Learn found here: https://github.com/MicrosoftDocs/learn-pr

@a-a-ron I updated the content. FYI @camihmerhar 
- I added expand/collapse and bulleted lists for the module lists.
- I added a, Helpful resources, section with links. And a, Hubbers resources, section. Both with short summaries.
- I updated the summary adding in a statement about the repo.
@rmallorybpc
Copy link
Collaborator Author

@a-a-ron I updated the content. FYI @camihmerhar

  • I added expand/collapse and bulleted lists for the module lists.
  • I added a, Helpful resources, section with links. And a, Hubbers resources, section. Both with short summaries.
  • I updated the summary adding in a statement about the repo.

Added, Expand for the GitHub Administration modules:, set for each module grouping. Thanks @camihmerhar.
@rmallorybpc
Copy link
Collaborator Author

Added, Expand for the GitHub Administration modules:, set for each module grouping. Thanks @camihmerhar.

@a-a-ron a-a-ron merged commit 43ae413 into main Jun 27, 2023
@a-a-ron a-a-ron deleted the rmallorybpc-mslearn-readme-updates branch June 27, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants