Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Fix typo and update token call for "14_js-files-activity.md" #32

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

dnly09
Copy link
Contributor

@dnly09 dnly09 commented Dec 25, 2020

Identified two items with the "14_js-files-activity.md" file:

  • .github/actions/issue-makes/index.js to .github/actions/issue-maker/index.js
  • github.GitHub(token) to github.getOctokit(token)

@github-learning-lab
Copy link

Your draft course version was created!


You can edit it using the Course Builder UI!

@kn0rki
Copy link

kn0rki commented Jan 1, 2021

hi,

did the lab for hours ago.
I wonder why here is the filename index.js but in the 2 other actions there is it main.js?
any reason for this?

Got and error message that the constructor github.GitHub not exist until i replaced it with github.getOctokit.
This is changed in 14_create-js-files.md but not in 14_js-files-activity.md.

@heiskr heiskr merged commit 44e5909 into githubtraining:main Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants