Skip to content

Conversation

jlo1
Copy link
Contributor

@jlo1 jlo1 commented Sep 26, 2017

Currently the workaround is to pass the width of the parent container to the child rows. Would be ideal if children rows just auto-fit into the width (or height, if horizonal list) of their parents.

Thanks @gitim for all the work you've put into this library, btw!

@gitim
Copy link
Owner

gitim commented Sep 26, 2017

Seems https://github.com/gitim/react-native-sortable-list/blob/master/src/SortableList.js#L212-L220 is not needed now, also could u move these styles into styles

@jlo1
Copy link
Contributor Author

jlo1 commented Sep 27, 2017

Good call on removing those lines. Regarding moving it into styles, I left it since they were dependent on whether the list is horizontal or not, and also to be consistent with lines here: https://github.com/gitim/react-native-sortable-list/blob/master/src/SortableList.js#L179.

But if you'd prefer, I can create horizontalContainer {top: 0, bottom: 0} and verticalContainer {left: 0, right: 0} , and reference those instead? Whatever you prefer!

Thanks!

@gitim
Copy link
Owner

gitim commented Sep 27, 2017

But if you'd prefer, I can create horizontalContainer {top: 0, bottom: 0} and verticalContainer {left: 0, right: 0} , and reference those instead?

yes, I meant this

@jlo1
Copy link
Contributor Author

jlo1 commented Sep 27, 2017

Done! Thanks @gitim!

@gitim gitim merged commit c1a6993 into gitim:master Sep 30, 2017
@gitim
Copy link
Owner

gitim commented Sep 30, 2017

Released in 0.0.17. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants