Skip to content

[projectmanager] fixed moving of issues #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Conversation

JanKoehnlein
Copy link
Contributor

@JanKoehnlein JanKoehnlein commented Oct 22, 2021

The main change is to correct the args in the call to FindCardByIssueURL

Fixes #33

NONE

@JanKoehnlein
Copy link
Contributor Author

Is already deployed

@JanKoehnlein
Copy link
Contributor Author

/approve no-issue

@roboquat
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: JanKoehnlein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JanKoehnlein
Copy link
Contributor Author

What we should do as well:

  • Let groundwork only add labels and check column quotas
  • Let only projectmanager move cards between columns,
  • Add Inbox (no groundwork label, open) and Deployed (no groundwork label, closed) at the end of the managed columns to projectmanager. This way, pm will always move issues into the right column based on the labels.
  • Let projectmanager also sort high priority issues to top.

@roboquat roboquat merged commit 4ecfc32 into main Oct 25, 2021
@roboquat roboquat deleted the jk/fix-projectmanager branch October 25, 2021 07:55
@roboquat
Copy link

@JanKoehnlein: Updated the projectmanager configmap in namespace prow at cluster default using the following files:

  • key projectmanager.yaml using file config/projectmanager.yaml

In response to this:

The main change is to correct the args in the call to FindCardByIssueURL

Fixes #33

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JanKoehnlein
Copy link
Contributor Author

TO avoid the deployed state and the code get out sync, I added LGTM manually. Feel free to revert if necessary

@@ -17,6 +17,7 @@ import (
func FindCardByIssueURL(gh github.Client, org, repo string, number int, col int) (cardID *int, err error) {
issueURL := fmt.Sprintf("https://github.com/api/repos/%s/%s/issues/%v", org, repo, number)

// Funny fact: this also returns cards from other columns, even in other projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 25, 2021

Thanks for fixing this @JanKoehnlein! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roboquat does not move issues to review column in groundwork even if labels are applied correctly
3 participants