-
Notifications
You must be signed in to change notification settings - Fork 6
[projectmanager] fixed moving of issues #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is already deployed |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: JanKoehnlein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What we should do as well:
|
@JanKoehnlein: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
TO avoid the deployed state and the code get out sync, I added LGTM manually. Feel free to revert if necessary |
@@ -17,6 +17,7 @@ import ( | |||
func FindCardByIssueURL(gh github.Client, org, repo string, number int, col int) (cardID *int, err error) { | |||
issueURL := fmt.Sprintf("https://github.com/api/repos/%s/%s/issues/%v", org, repo, number) | |||
|
|||
// Funny fact: this also returns cards from other columns, even in other projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
Thanks for fixing this @JanKoehnlein! 🙏 |
The main change is to correct the args in the call to FindCardByIssueURL
Fixes #33