Skip to content

Fix auth validation #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Fix auth validation #6

merged 2 commits into from
Jul 15, 2022

Conversation

jeanp413
Copy link
Member

Related Issue(s)

Fixes gitpod-io/gitpod#11296

How to test

  1. Run this extension
  2. Connect to a workspace in any prev env (use SSH gateway) you can use this one https://jp-heartbeat-test.preview.gitpod-dev.com/workspaces
  3. After successful connection, delete the gitpod token from database, or you can rebuild the prev env with with-clean-slate-deployment so DB gets recreated
  4. Try to connect again to a workspace it should ask to login again and not fail silently as before

Release Notes

NONE

@andreafalzetti
Copy link

andreafalzetti commented Jul 13, 2022

Could you share how to delete the token from the DB? I would like to test it with another prev env which I don't own, because the one in PR description is down I think. And I don't want to reset someone else prev env state :)

At the same time I am trying to create a new prev env, but I am having issues with it [1]

@jeanp413
Copy link
Member Author

jeanp413 commented Jul 13, 2022

@andreafalzetti check slack message to how to connect to db

Copy link

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as advertised

@jeanp413 jeanp413 merged commit 01a663a into master Jul 15, 2022
@jeanp413 jeanp413 deleted the jp/fix-auth-validation branch July 15, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify Gitpod token in vscode-desktop is valid
3 participants