Skip to content

Commit cfc1d71

Browse files
committed
[workspace] hide ide alert on stop phase (#11035)
1 parent 2d4f946 commit cfc1d71

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

components/dashboard/src/start/StartWorkspace.tsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
451451
let phase: StartPhase | undefined = StartPhase.Preparing;
452452
let title = undefined;
453453
let isTimedOut = false;
454+
let isStoppingOrStopped = false;
454455
let statusMessage = !!error ? undefined : <p className="text-base text-gray-400">Preparing workspace …</p>;
455456
const contextURL = ContextURL.getNormalizedURL(this.state.workspace)?.toString();
456457
const useLatest = !!this.state.workspaceInstance?.configuration?.ideConfig?.useLatest;
@@ -624,6 +625,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
624625

625626
// Stopping means that the workspace is currently shutting down. It could go to stopped every moment.
626627
case "stopping":
628+
isStoppingOrStopped = true;
627629
if (isPrebuild) {
628630
return (
629631
<StartPage title="Prebuild in Progress">
@@ -661,6 +663,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
661663

662664
// Stopped means the workspace ended regularly because it was shut down.
663665
case "stopped":
666+
isStoppingOrStopped = true;
664667
phase = StartPhase.Stopped;
665668
if (this.state.hasImageBuildLogs) {
666669
const restartWithDefaultImage = (event: React.MouseEvent) => {
@@ -712,7 +715,12 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
712715
break;
713716
}
714717
return (
715-
<StartPage phase={phase} error={error} title={title} showLatestIdeWarning={!isTimedOut && useLatest}>
718+
<StartPage
719+
phase={phase}
720+
error={error}
721+
title={title}
722+
showLatestIdeWarning={!isTimedOut && !isStoppingOrStopped && useLatest}
723+
>
716724
{statusMessage}
717725
</StartPage>
718726
);

0 commit comments

Comments
 (0)