Skip to content

Remove the latest editor release warning alert on workspace time out #11035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Jun 30, 2022 · 3 comments · Fixed by #16940 or #18336
Closed

Remove the latest editor release warning alert on workspace time out #11035

gtsiolis opened this issue Jun 30, 2022 · 3 comments · Fixed by #16940 or #18336
Assignees
Labels
aspect: browser IDE editor: code (browser) meta: never-stale This issue can never become stale team: IDE type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jun 30, 2022

Bug description

Back in #8783, we introduced a warning alert to notify users when they've opted in for using the latest editor release for workspaces.

This is also shown on the workspace pages like Timed Out, Stopping, Stopped which can be inaccurate as the user may have changed the setting in the meantime.

Instead, relying on showing this warning during workspace (re)start could be better.

When the latest warning should be shown

  • It's before or (re)starting the workspace -> ref to phases
    function getPhaseTitle(phase?: StartPhase, error?: StartWorkspaceError) {
    if (!!error) {
    return "Oh, no! Something went wrong!";
    }
    switch (phase) {
    case StartPhase.Checking:
    return "Checking";
    case StartPhase.Preparing:
    return "Preparing";
    case StartPhase.Creating:
    return "Creating";
    case StartPhase.Starting:
    return "Starting";
    case StartPhase.Running:
    return "Starting";
    case StartPhase.IdeReady:
    return "Running";
    case StartPhase.Stopping:
    return "Stopping";
    case StartPhase.Stopped:
    return "Stopped";
    default:
    return "";
    }
    }
  • Workspaces start/stopped failed for some unexpected reasons (i.e. with exit code from supervisor) -> when it shows error
    {error && <StartError error={error} />}

Steps to reproduce

  1. Go to /preferences and opt in for the Latest Release (Unstable) option.
  2. Open a new workspace and let it time out (~30 min)
  3. Notice the on the Timed Out page we're still showing the latest editor release warning alert.

Screenshot 2022-06-30 at 1 34 34 PM

@stale
Copy link

stale bot commented Oct 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label Oct 17, 2022
@gtsiolis
Copy link
Contributor Author

Still relevant, marking as ~never-stale.

@Devansu-Yadav
Copy link
Contributor

@gtsiolis As there was no assignee for this issue, I thought of resolving it by raising #16551, as it was a trivial change and is still valid (I was able to reproduce this issue).

Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Mar 9, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Mar 21, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Mar 23, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Mar 23, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Mar 28, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Mar 28, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Apr 4, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Apr 4, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Apr 11, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Apr 11, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Apr 18, 2023
Devansu-Yadav added a commit to Devansu-Yadav/gitpod that referenced this issue Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: browser IDE editor: code (browser) meta: never-stale This issue can never become stale team: IDE type: improvement Improves an existing feature or existing code
Projects
None yet
2 participants