Skip to content

Remove deprecated image build log mechanism #11024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geropl opened this issue Jun 30, 2022 · 4 comments · Fixed by #11026 or #12351
Closed

Remove deprecated image build log mechanism #11024

geropl opened this issue Jun 30, 2022 · 4 comments · Fixed by #11026 or #12351
Assignees
Labels
component: dashboard component: server type: improvement Improves an existing feature or existing code

Comments

@geropl
Copy link
Member

geropl commented Jun 30, 2022

In order to move image-builder to the workspace cluster, we need to ensure we use the same log streaming mechanism for image builds as for prebuilds.
This issues is about rolling this out to prod (feature flagged) to verify it actually does work, and then roll it out to all users.

Context: #9337

@geropl geropl added component: dashboard component: server type: improvement Improves an existing feature or existing code labels Jun 30, 2022
@geropl geropl self-assigned this Jun 30, 2022
@geropl geropl moved this to In Progress in 🍎 WebApp Team Jun 30, 2022
Repository owner moved this from In Progress to Done in 🍎 WebApp Team Jul 1, 2022
@geropl
Copy link
Member Author

geropl commented Jul 1, 2022

Re-opening because we have to cleanup the feature flag in ~a week.

@geropl geropl reopened this Jul 1, 2022
Repository owner moved this from Done to In Progress in 🍎 WebApp Team Jul 1, 2022
@geropl
Copy link
Member Author

geropl commented Jul 8, 2022

Just checked the logs:

  • there are no entries that the old code path has been taken the last 7 weeks (link)
  • there are not entries that deprecating the new path triggered any errors during my manual tests (link)

Rolled this out to:

  • staging & dev
  • prod: Segment "Gitpod Internal" (waiting for rollout of this PR)

@geropl
Copy link
Member Author

geropl commented Jul 13, 2022

I noticed a "empty log" situation with an image-build for a prebuild the other day on the "Prebuild Details" view.
Status and "Skip Prebuild" were shown, but no logs appeared. Re-loading fixed it.

My suspicion is that either:

  1. the getWorkspaceInfo thing failed. I thought we'd see an red error message in the log view, but maybe I missed sth?
  2. the getImageBuildLogs did exit due to an escalated error
  3. getImageBuildLogs registration got "removed" by a websocket disconnect

Update: This as a separate issue, and even a separate piece of code 🙈 So, not relevant here.

@geropl
Copy link
Member Author

geropl commented Aug 24, 2022

The changes have been rolled out. Only thing missing is a PR removing the feature flag and dead code.

Repository owner moved this from In Progress to Done in 🍎 WebApp Team Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard component: server type: improvement Improves an existing feature or existing code
Projects
Status: Done
1 participant