Skip to content

Reliably fetch logs for imagebuild and prebuild itself #11026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jun 30, 2022

Description

This PR deprecates an older mechanism to stream image build logs. Removing that revealed that it was shadowing reliabilty problems, so those got fixed in the frontend as well. 🙈

I hid the changes behind a feature flag to safely test the effects in staging + prod (different ingress infrastructure).

Related Issue(s)

Fixes #11024

How to test

  • create a team and project (e.g. on this test repo)
  • push a commit, for instance to this branch
  • switch to "Branches", wait for the prebuild to start and click on the Prebuild Details view
  • open a second tab on "Branches", and once the prebuild is there, click "start workspace" right next to it
  • observe that a) streaming of image build logs and b) streaming of prebuild logs works as expected
  • go to ConfigCat, and add a filter for your project to include the projectId and set the flag deprecateOldImageLogsMechanism to true
  • repeat tests above ☝️

Release Notes

Improve reliability of log streaming for image builds and prebuilds

Documentation

Werft options:

  • /werft with-preview

@geropl
Copy link
Member Author

geropl commented Jun 30, 2022

@jldec I just tested, and it worked nicely for me. 👍 Do you want to have a look?

Note: the status message does not fit. We can improve that in a follow-up.
image

@geropl geropl marked this pull request as ready for review June 30, 2022 11:45
@geropl geropl requested a review from a team June 30, 2022 11:45
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 30, 2022
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Image bulld logs appear properly for both prebuild-detail and start-workspace views.

(I was unable to figure out how to test the code path where the feature flag determines whether to show an error or use the old mechanism)

/hold in case you want to clarify or do more technical review

@geropl
Copy link
Member Author

geropl commented Jul 1, 2022

(I was unable to figure out how to test the code path where the feature flag determines whether to show an error or use the old mechanism)

Sorry, should have explained 🙇 But I think it's fine as is, already did that twice yesterday.
Thank you! 🙏

/unhold

@roboquat roboquat merged commit c43a6c9 into main Jul 1, 2022
@roboquat roboquat deleted the gpl/11024-imglogs branch July 1, 2022 06:39
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated image build log mechanism
3 participants