-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Dockerfile always rebuilding with "Incremental Prebuilds" enabled #11455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I noticed this in the past - but failed to report it, sorry. IIRC in my case the container wasn't build each time but most times, and also I don't think I had incremental prebuilds enabled. I couldn't figure out any pattern. But in any event it was rebuilt even though I had not pushed an updated This is a large time sink as docker container builds especially off of Gitpod.io's "workspace-full" container, are quite slow. And that defeats the main selling points of Gitpod.io - "Select project, start coding." I think the custom container should only be updated on two occasions when doing a prebuild (or loading a workspace that hasn't been prebuilt):
(As to discovering whether the image now at the tag is the same or different that the image that was last used in a customer dockerfile build: that's left as "an exercise for the reader" as my brief reading of various issues at Docker show that identifying a particular image is a hairball ... - but I'm no docker registry expert ...) |
Hey @csweichel - is this bug-fix being worked upon? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Uh oh!
There was an error while loading. Please reload this page.
Bug description
I have Incremental Prebuilds enabled for my project (https://gitpod.io/projects/rdflib/settings), however every time I commit to a PR branch the docker build starts from scratch as far as I can tell.
Steps to reproduce
Workspace affected
https://gitpod.io/#https://github.com/aucampia/rdflib/tree/iwana-20220718T2235-gitpod-issue
Expected behavior
Each update to README.md after the first prebuild does not do a full docker build
Example repository
https://github.com/aucampia/rdflib/tree/iwana-20220718T2235-gitpod-issue
Anything else?
No response
The text was updated successfully, but these errors were encountered: