Skip to content

Update usage page colors in dark theme #11527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Jul 21, 2022 · 3 comments
Closed

Update usage page colors in dark theme #11527

gtsiolis opened this issue Jul 21, 2022 · 3 comments
Labels
component: dashboard feature: billing meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

Problem to solve.

Following up from #11481, the new usage page contains a table and a new sidebar design that does not render well in dark theme regarding color accessibility and information hierarchy.

Light Theme Dark Theme Dark Theme (Table Hover)
Screenshot 2022-07-21 at 2 50 17 PM (2) Screenshot 2022-07-21 at 2 50 35 PM (2) Screenshot 2022-07-21 at 2 50 36 PM (2)

FWIW, the table used here could be using the same exactly table component as in the new blocked repositories layout (see #11446) which is also suffering from similar issues regarding the dark theme, see point [16] in #11463:

  1. Improve dark theme colors. 🌔
@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team feature: billing labels Jul 21, 2022
@gtsiolis
Copy link
Contributor Author

Cross-posting designs from #11640 (comment):

Dark theme
usage-dark

@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 9, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 9, 2022

Closing this as usage layout and colors have been updated.

@gtsiolis gtsiolis closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: billing meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

1 participant