Skip to content

Polish blocked repositories page layout #11463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
9 of 18 tasks
gtsiolis opened this issue Jul 19, 2022 · 4 comments
Open
9 of 18 tasks

Polish blocked repositories page layout #11463

gtsiolis opened this issue Jul 19, 2022 · 4 comments
Labels
feature: admin dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 19, 2022

Problem to solve

Follow-up UX from #11446.

  • 1. Use red text color for the delete option in the more actions dropdown, see [dashboard] BlockedRepo UI #11446 (comment).
  • 2. Improve empty input validation error. Replace Empty RegEx! with Repository URL can not be empty.
  • 3. Improve table design (thinner rows in height)
  • 4. Improve table header (borderless design)
  • 5. Improve table binary option for indicating blocking users toggle with text or an icon, see [dashboard] BlockedRepo UI #11446 (comment).
  • 6. Improve input placeholder, see [dashboard] BlockedRepo UI #11446 (comment).
  • 7. Use an alert component to inform user about search input flexibity or limitations, see [dashboard] BlockedRepo UI #11446 (comment).
  • 8. Use an alert component to inform the user that RegEx is supported while adding a new blocked repository.
  • 9. Remove the Delete table header, the more actions column does not need a table header.
  • 10. Move the Block User slightly more to the left for better white space usage and visual balance.
  • 11. Improve table typography, see colors, font size and font weight in the linked design specs below.
  • 12. Rename Block User to Block Users in the new blocked repository modal.

Additional things to consider:

  • 13. Adding the EDIT functionality using the same modal.
  • 14. Use an alert component (warning variant) to warn users, this can affect all instance users.
  • 15. Surface the admin user who added each blocked repository, for system visibility.
  • 16. Improve dark theme colors. 🌔
  • 17. Introduce Updated date column and indicate sorting order.
  • 18. Remove the Blocked Users section within the modal when deleting a blocked repository. ❗

See design specs.

Block Users (Text) Block Users (Icon) New Blocked Repository (Modal)
BlockedRepositoriesList BlockedRepositoriesList-1 BlockedRepositoriesModal
@gtsiolis gtsiolis added feature: admin dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Jul 19, 2022
@gtsiolis
Copy link
Contributor Author

@geropl I was planning to mark these as a ~good-first-issue but saw that you already opened #11462 to address most of these issues. Feel free to leave out of #11462 anything that increases the scope of the PR as a new follow-up issue.

@geropl
Copy link
Member

geropl commented Jul 19, 2022

  1. Surface the admin user who added each blocked repository, for system visibility.

Excellent idea! 💡 I long planned to add an epic for this, now there is one.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jul 20, 2022

@geropl I've silently added in the issue description 4-5 more tasks to keep track of these but should be fine to also break these into a separate issue if we'd like to unblock merging #11462.

homer-simpson

@stale
Copy link

stale bot commented Dec 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 16, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: admin dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

2 participants