Skip to content

Replace column sorting icon in usage page #11783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #9036
gtsiolis opened this issue Aug 1, 2022 · 1 comment · Fixed by #11815
Closed
Tracked by #9036

Replace column sorting icon in usage page #11783

gtsiolis opened this issue Aug 1, 2022 · 1 comment · Fixed by #11815
Assignees
Labels

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 1, 2022

Problem to solve

Back in #11774, a new sorting icon was added in the column header.

Cc @laushinka @easyCZ

The Arrow component was used. However:

  1. We've been using a different arrow for the sorting icon in columns across the product. For example, see 🅰️ /t/gitpod/members or 🅱️ /admin/teams.
  2. The sorting icon used in the usage based is used for indicating a dropdown button which could be confusing to what to expect when clicking on that area.
Sorting icon Dropdown icon
Screenshot 2022-08-02 at 9 52 04 AM Screenshot 2022-08-02 at 9 53 40 AM

Proposal

Replace column sorting icon in usage page with the sorting arrow used across the product for indicating column sorting.

@laushinka
Copy link
Contributor

@gtsiolis Thank you for the quick response! I had a feeling the icon seemed different but I totally forgot 🤣

@laushinka laushinka self-assigned this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants