Replace with sorting icon #11815
Merged
Replace with sorting icon #11815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-laushinka-replace-column-sorting-11783.1 because the annotations in the pull request description changed |
laushinka
force-pushed
the
laushinka/replace-column-sorting-11783
branch
2 times, most recently
from
22f1baa to
37eb94d
Compare
laushinka
force-pushed
the
laushinka/replace-column-sorting-11783
branch
from
da1eacf to
4e46af5
Compare
|
@gtsiolis How do I rotate the SVG? 🤣 I tried using |
gtsiolis
reviewed
Aug 3, 2022
| @@ -204,7 +204,9 @@ function TeamUsage() { | |||
| <ItemField className="my-auto cursor-pointer"> | |||
| <span onClick={() => setIsStartedTimeDescending(!isStartedTimeDescending)}> | |||
| Started | |||
| <Arrow direction={isStartedTimeDescending ? "down" : "up"} /> | |||
| <SortArrow | |||
| className={`h-4 w-4 ${isStartedTimeDescending ? "" : "rotate-180"}`} | |||
There was a problem hiding this comment.
@laushinka Regarding the question about rotation in #11815 (comment), you'll need to add the transform class here for this to work, right? See relevant docs for 2.x v. 3.x.
There was a problem hiding this comment.
LOL thank you as always @gtsiolis!
Closed
laushinka
force-pushed
the
laushinka/replace-column-sorting-11783
branch
from
4e46af5 to
a19f7a5
Compare
roboquat
added
release-note-none
and removed
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
labels
andrew-farries
approved these changes
Aug 3, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the correct arrow icon.
Related Issue(s)
Fixes #11783
How to test
Release Notes
Documentation
Werft options: