-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Pagination links not properly themed #12537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Besides the styling issues, pagination also comes with some usability issues, see #12027.
|
Thanks by the way for noticing, @svenefftinge! 🏀 For the styling issues, the initial design specs linked in #12027, #11483, and #11285 should already cover what we need to change here. Just added also some detailed designs for the dark theme in case this helps. ✔️ Re-posting the designs here for visibility:
|
Hey, @gtsiolis @svenefftinge I would like to work on this issue |
Awesome! Thank you @Hardik500. |
@Hardik500 You can find the detailed design specs linked above in #12537 (comment). Feel free to open a PR and link back to this issue. 🏓 |
Thanks for the reference @gtsiolis |
@gtsiolis In terms of adding new styling changes, do I also have to add the styling that is related to mobile and compact displays? |
#12537 (comment) |
@Hardik500 Feel free to skip anything related to responsive layout. In the spirit of our ship skateboards value, we can always break down the issue into smaller pieces and open a follow-up issue for the mobile layout. 🛹 Also, the infinite scrolling has been brought up in #11483 but we decided to opted for pagination component for now. |
The links on the bottom of a paginated table are not properly themed.
The text was updated successfully, but these errors were encountered: