Skip to content

Pagination links not properly themed #12537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svenefftinge opened this issue Aug 31, 2022 · 9 comments · Fixed by #13590
Closed

Pagination links not properly themed #12537

svenefftinge opened this issue Aug 31, 2022 · 9 comments · Fixed by #13590
Assignees
Labels

Comments

@svenefftinge
Copy link
Member

The links on the bottom of a paginated table are not properly themed.

Screenshot 2022-08-31 at 08 57 20

@gtsiolis
Copy link
Contributor

Besides the styling issues, pagination also comes with some usability issues, see #12027.

  1. Use the while button area as an active hover area instead of just the number
  2. ...

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 31, 2022

Thanks by the way for noticing, @svenefftinge! 🏀

For the styling issues, the initial design specs linked in #12027, #11483, and #11285 should already cover what we need to change here.

Just added also some detailed designs for the dark theme in case this helps. ✔️

Re-posting the designs here for visibility:

Light Theme Dark Theme
pagination-light-theme pagination-dark-theme

@Hardik500
Copy link
Contributor

Hey, @gtsiolis @svenefftinge I would like to work on this issue

@svenefftinge
Copy link
Member Author

Awesome! Thank you @Hardik500.

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 3, 2022

@Hardik500 You can find the detailed design specs linked above in #12537 (comment).

Feel free to open a PR and link back to this issue. 🏓

@Hardik500
Copy link
Contributor

Thanks for the reference @gtsiolis

@Hardik500
Copy link
Contributor

@gtsiolis In terms of adding new styling changes, do I also have to add the styling that is related to mobile and compact displays?
Also, what about infinite displays, cause I am not seeing that being handled right now?

@Hardik500
Copy link
Contributor

#12537 (comment)
@gtsiolis @svenefftinge thoughts?

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 4, 2022

@Hardik500 Feel free to skip anything related to responsive layout.

In the spirit of our ship skateboards value, we can always break down the issue into smaller pieces and open a follow-up issue for the mobile layout. 🛹

Also, the infinite scrolling has been brought up in #11483 but we decided to opted for pagination component for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants