Skip to content

[supervisor] close of closed channel panic #14014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sagor999 opened this issue Oct 19, 2022 · 2 comments · Fixed by #14230
Closed

[supervisor] close of closed channel panic #14014

sagor999 opened this issue Oct 19, 2022 · 2 comments · Fixed by #14230
Assignees

Comments

@sagor999
Copy link
Contributor

Bug description

While terminating workspace, noticed this in log output from workspace pod:

Connection closed by UNKNOWN port 65535                            
debug1: channel 0: free: server-session, nchannels 1               
Close session: user gitpod from UNKNOWN port 65535 id 0            
debug1: do_cleanup                                                 
Transferred: sent 691708, received 1028712 bytes                   
Closing connection to UNKNOWN port 65535                           
mm_request_send: write: Broken pipe                                
debug1: do_cleanup                                                 
panic: close of closed channel                                     
                                                                   
goroutine 81 [running]:                                            
github.com/gitpod-io/gitpod/supervisor/cmd.glob..func3.2()         
    github.com/gitpod-io/gitpod/supervisor/cmd/init.go:87 +0xb8    
created by github.com/gitpod-io/gitpod/supervisor/cmd.glob..func3  
    github.com/gitpod-io/gitpod/supervisor/cmd/init.go:83 +0x79e   

Seems to be this line:

close(supervisorDone)

Steps to reproduce

close workspace

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@akosyakov
Copy link
Member

@iQQBot Maybe you can have a look while on-call?

@akosyakov akosyakov moved this to Scheduled in 🚀 IDE Team Oct 24, 2022
@iQQBot iQQBot self-assigned this Oct 24, 2022
@iQQBot
Copy link
Contributor

iQQBot commented Oct 24, 2022

will take a look

Repository owner moved this from Scheduled to Done in 🚀 IDE Team Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants