Skip to content

[supervisor] remove unnecessary close channel #14230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Oct 27, 2022

Description

[supervisor] remove unnecessary close channel

Related Issue(s)

Fixes #14014

How to test

  1. start workspace with this branch in gitpod.io, connect to preview environment via kubectl
  2. start a workspace in preview environment, it should work
  3. use kubectl get pods -l component=workspace to get workspace pod name
  4. use kubectl logs ws-xxxxxx -f to see workspace log
  5. stop your workspace, and observe log, there should not have panic: close of closed channel error output

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@iQQBot iQQBot requested a review from a team October 27, 2022 10:30
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-iqqbot-supervisor-close-of-closed-14014.1 because the annotations in the pull request description changed
(with .werft/ from main)

@iQQBot
Copy link
Contributor Author

iQQBot commented Oct 27, 2022

/werft run

👍 started the job as gitpod-build-iqqbot-supervisor-close-of-closed-14014.2
(with .werft/ from main)

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 9bf2aa1 into main Oct 28, 2022
@roboquat roboquat deleted the iqqbot/supervisor-close-of-closed-14014 branch October 28, 2022 06:30
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[supervisor] close of closed channel panic
3 participants