Skip to content

Better surface errors when Gitpod fails to get your Stripe subscription details #14034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jankeromnes opened this issue Oct 20, 2022 · 1 comment · Fixed by #14180
Closed
Assignees
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@jankeromnes
Copy link
Contributor

Bug description

When Gitpod fails to find your Stripe Subscription ID (for example, if your team has 2 Stripe Customers due to another bug), our UI is quite confusing:

  • Your team's billing UI shows as if you were not subscribed at all (thus encouraging you to try and upgrade again 🙈)
  • Your personal billing UI's "Default Billing Account" selector remains pending forever

In both cases, this error is shown in the browser console:

Uncaught (in promise) Error: Failed to get Stripe Subscription ID for 'team:6d59097c-cbb7-4dc0-b7d5-9aa27452ccc0'

Also, in the server logs, the actual error appears, e.g.:

ClientError: /usage.v1.BillingService/GetStripeCustomer FAILED_PRECONDITION: found multiple customers for attributiuon_id: team:6d59097c-cbb7-4dc0-b7d5-9aa27452ccc0

Steps to reproduce

  1. Upgrade your team to usage-based
  2. Create a second Stripe Customer that has the same metadata (attributionId: "team:1234")
  3. Visit your team's billing UI (looks like you're not subscribed)
  4. Visit your user's billing UI (default billing account selector is pending forever)

Workspace affected

No response

Expected behavior

In both pages, Gitpod should at least show some sort of error message, thus giving the user a hint that something is wrong.

Something like this, for example:

Error while getting your subscription details: Gitpod encountered an error while getting your team's subscription details. Please contact support

Example repository

No response

Anything else?

No response

@jankeromnes jankeromnes added type: bug Something isn't working component: dashboard team: webapp Issue belongs to the WebApp team labels Oct 20, 2022
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 20, 2022

Screenshots

Wait, didn't I already subscribe? Default billing account is pending forever + console
Screenshot 2022-10-20 at 14 34 44 Screenshot 2022-10-20 at 14 37 50

@geropl geropl moved this to Scheduled in 🍎 WebApp Team Oct 21, 2022
@jankeromnes jankeromnes self-assigned this Oct 24, 2022
@jankeromnes jankeromnes changed the title Better surface errors when Gitpod fails to find your Stripe Subscription ID Better surface errors when Gitpod fails to get your Stripe subscription details Oct 26, 2022
@jankeromnes jankeromnes moved this from Scheduled to In Progress in 🍎 WebApp Team Oct 26, 2022
Repository owner moved this from In Progress to In Validation in 🍎 WebApp Team Oct 26, 2022
@jankeromnes jankeromnes moved this from In Validation to Done in 🍎 WebApp Team Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Status: Done
1 participant