Skip to content

[dashboard] Better surface errors when Gitpod fails to get your Stripe subscription details #14180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Oct 26, 2022

Description

In some rare edge cases, it can happen that Gitpod fails to get your Stripe subscription details (for example, one of these cases can be that a Stripe customer has two active Subscriptions for some reason, but there could exist other rare edge cases).

In these cases, Gitpod's backend throws an error. However, until now, the front-end only logged this error to the console, without showing it visibly in the UI. This PR fixes the latter, by visibly showing any such error message in the UI, so that users are at least aware that something went wrong.

Related Issue(s)

Fixes #14034

How to test

  1. Upgrade your team to usage-based
  2. In the Stripe test dashboard, manually create a duplicate Subscription for your team's Customer (pick any subscription details)
  3. Visit your team's billing UI -- an error message should be shown near the top

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jx-better-surface-subscription-errors.1 because the annotations in the pull request description changed
(with .werft/ from main)

@jankeromnes jankeromnes force-pushed the jx/better-surface-subscription-errors branch from dac504e to 3fcf430 Compare October 26, 2022 13:44
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 26, 2022

Works! 🎉

Screenshot 2022-10-26 at 15 44 33

@jankeromnes jankeromnes force-pushed the jx/better-surface-subscription-errors branch from 3fcf430 to ab984d7 Compare October 26, 2022 13:47
@jankeromnes jankeromnes marked this pull request as ready for review October 26, 2022 13:47
@jankeromnes jankeromnes requested a review from a team October 26, 2022 13:47
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 26, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit ac8b803 into main Oct 26, 2022
@roboquat roboquat deleted the jx/better-surface-subscription-errors branch October 26, 2022 14:13
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better surface errors when Gitpod fails to get your Stripe subscription details
3 participants