Skip to content

[ws-manager & image-builder-mk3] status is logged as string, instead of object #14219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kylos101 opened this issue Oct 27, 2022 · 1 comment · Fixed by #14905
Closed

[ws-manager & image-builder-mk3] status is logged as string, instead of object #14219

kylos101 opened this issue Oct 27, 2022 · 1 comment · Fixed by #14905
Assignees
Labels
type: bug Something isn't working

Comments

@kylos101
Copy link
Contributor

kylos101 commented Oct 27, 2022

⚠️ Be careful the status object contains sensitive information

Bug description

Status is logged as string, instead of a JSON object. We can find and read this easy enough, but, we cannot select child values to filter by or present on the summary.

Refer to jsonPayload.status in this example.

Steps to reproduce

  1. Log an error here
  2. View the log in Stackdriver for your preview environment

Workspace affected

No response

Expected behavior

Try changing the files altered here, so that status is an well formed JSON object, instead of a string.

This might be a side effect of the log redaction that we have to live with. 🤷

Example repository

No response

Anything else?

In this, we redacted the object, but output log as a base64 encoded string - which is not able to be easily searched and read in Stackdriver.

In this, we output the string object, so its easily searched and read, but not organized or filtered in Stackdriver.

@kylos101 kylos101 added the type: bug Something isn't working label Oct 27, 2022
@kylos101 kylos101 moved this to Breakdown in 🌌 Workspace Team Oct 27, 2022
@atduarte atduarte moved this from Breakdown to Scheduled in 🌌 Workspace Team Nov 8, 2022
@jenting jenting self-assigned this Nov 21, 2022
@jenting jenting moved this from Scheduled to In Progress in 🌌 Workspace Team Nov 21, 2022
Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Nov 24, 2022
@kylos101
Copy link
Contributor Author

Thanks, @jenting ! 💪

@kylos101 kylos101 moved this from Awaiting Deployment to In Validation in 🌌 Workspace Team Dec 9, 2022
@kylos101 kylos101 moved this from In Validation to Awaiting Deployment in 🌌 Workspace Team Dec 9, 2022
@WVerlaek WVerlaek moved this from Awaiting Deployment to In Validation in 🌌 Workspace Team Dec 9, 2022
@jenting jenting moved this from In Validation to Done in 🌌 Workspace Team Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants