Skip to content

Log JSON as an object instead of a string #14905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Log JSON as an object instead of a string #14905

merged 2 commits into from
Nov 24, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Nov 24, 2022

Description

Log JSON as an object instead of a string.

Related Issue(s)

Fixes #14219

How to test

  • Update the ws-manager deployment LOG_LEVEL to DEBUG
  • Start a workspace
  • Check the ws-manager log

Here is an example log output https://cloudlogging.app.goo.gl/GtxqVmV7w7Y564qR9

Release Notes

None

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@jenting jenting requested a review from a team November 24, 2022 05:02
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Nov 24, 2022
@roboquat roboquat merged commit 9e8b89e into main Nov 24, 2022
@roboquat roboquat deleted the jenting/14219 branch November 24, 2022 13:12
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-manager & image-builder-mk3] status is logged as string, instead of object
3 participants