Skip to content

Show enable prebuilds checkbox on new project creation #15281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jldec opened this issue Dec 10, 2022 · 4 comments
Closed

Show enable prebuilds checkbox on new project creation #15281

jldec opened this issue Dec 10, 2022 · 4 comments
Labels
⚙️ Groundwork meta: stale This issue/PR is stale and will be closed soon ❓ clarification required team: webapp Issue belongs to the WebApp team

Comments

@jldec
Copy link
Contributor

jldec commented Dec 10, 2022

Many projects do not need a prebuild, so running one when a new project is created, is confusing / surprising for users.

Also, the usage-collection for this prebuild is not working.

@jankeromnes
Copy link
Contributor

Many projects do not need a prebuild, so running one when a new project is created, is confusing / surprising for users.

Note: Running a first prebuild is currently the "trick" we use to "enable" prebuilds (i.e. a manually triggered prebuild will also install a webhook for future prebuilds to be run).

If we don't trigger a first prebuild, we will no longer enable prebuilds by default for each project (potentially surprising too? E.g. create a project, commit a .gitpod.yml with an init task... then still no prebuilds? 😳) -- the only way to "enable" prebuilds will then be for the user to click on a "Run Prebuild" button manually.

Also, do we want a way to "disable prebuilds" if you no longer need them?

Also, the usage-collection for this prebuild is not working.

This sounds like a separate bug that should also be fixed.

@svenefftinge
Copy link
Member

I think it would be good to ask the user to enable prebuilds (checkbox?) while creating the project. Also in the settings it would be great to be able to disable prebuilds which turns the entire prebuilds section disabled or folded. We could use this for the automatic disabling as well, so that users can enable manually again.

@jankeromnes jankeromnes moved this from Scheduled to In Progress in 🍎 WebApp Team Dec 26, 2022
@geropl geropl moved this from In Progress to Scheduled in 🍎 WebApp Team Jan 9, 2023
@geropl
Copy link
Member

geropl commented Jan 9, 2023

Dropped @jankeromnes as he's off, so we need to find some else to progress it.

@jldec jldec changed the title Stop triggering prebuilds on new project creation Show enable prebuilds checkbox on new project creation Jan 9, 2023
@geropl geropl removed the status in 🍎 WebApp Team Jan 23, 2023
@stale
Copy link

stale bot commented May 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 9, 2023
@stale stale bot closed this as completed Jun 11, 2023
@github-project-automation github-project-automation bot moved this to In Validation in 🍎 WebApp Team Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Groundwork meta: stale This issue/PR is stale and will be closed soon ❓ clarification required team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging a pull request may close this issue.

4 participants