Skip to content

Allow manually disabling prebuilds for a project #15435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Dec 20, 2022

Description

Allow manually disabling prebuilds for a project.

Related Issue(s)

Fixes #15281

How to test

  1. Create a project, but don't enable prebuilds
  2. Push a new commit to the project's repository
  3. There should be zero prebuilds in the project

Release Notes

Allow manually disabling prebuilds for a project

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jx-disable-prebuilds.3 because the annotations in the pull request description changed
(with .werft/ from main)

@jankeromnes jankeromnes force-pushed the jx/disable-prebuilds branch 2 times, most recently from 235c987 to 3677c7a Compare December 20, 2022 14:57
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Dec 20, 2022

/werft run cert-issuer=letsencrypt recreate-preview

👍 started the job as gitpod-build-jx-disable-prebuilds.6
(with .werft/ from main)

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Dec 20, 2022

/werft run cert-issuer=letsencrypt recreate-preview

👍 started the job as gitpod-build-jx-disable-prebuilds.8
(with .werft/ from main)

@jankeromnes jankeromnes force-pushed the jx/disable-prebuilds branch 2 times, most recently from 6f88f04 to dcb94e8 Compare December 27, 2022 10:10
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Dec 27, 2022

/werft run

👍 started the job as gitpod-build-jx-disable-prebuilds.12
(with .werft/ from main)

@roboquat roboquat added size/M and removed size/S labels Dec 28, 2022
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Dec 28, 2022

Okay, the UI is quite "basic" -- but now it works! 🎉 😁

New Project Project Settings
Screenshot 2022-12-28 at 16 45 35 Screenshot 2022-12-28 at 16 45 58

If you uncheck this (during project creation or in a project's settings), no new prebuilds will be triggered for that project (whether from a repository push or from a "Run Prebuild" button click).

Now we "just" need:

  • a good description text for the checkbox
  • a UX review
  • to decide what should happen to the other prebuild options if prebuilds are disabled
    • (though: what about turning the "Enable Prebuilds" checkbox into a toggle switch in the project settings, and then completely hide all other options when the switch is disabled?)

@gtsiolis @jldec and/or @selfcontained -- if you're not currently on holidays, would you mind giving this a quick look & sharing your thoughts? 👀 🙏

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 2, 2023

/werft run

👍 started the job as gitpod-build-jx-disable-prebuilds.16
(with .werft/ from main)

@stale
Copy link

stale bot commented Jan 16, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jan 16, 2023
@stale stale bot closed this Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon release-note size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show enable prebuilds checkbox on new project creation
3 participants