Skip to content

gp timeout set allows >24 hour timeout (and < 1s) #16085

Closed
@loujaybee

Description

@loujaybee

The docs for gp timeout set [1] states that the workspace timeout cannot be set to exceed 24 hours "maximum workspace timeout is 24 hours", however current gp timeout set allows for higher values than 24 hours to be entered.

  • Expected result: gp timeout set returns an error message if value is set higher than 24hours
  • Actual result: gp timeout set allows to set an above 24 hours value without error.

We should also set a sane upper and lower default: e.g. somewhere between 3 days to 1 week (requires discussion) which could potentially be overridden by contacting Gitpod directly, or in certain circumstances, however the current command allows you to set values into the 100's of years + (e.g. gp timeout set 2000000h => success, which is 228 years). Also the current command allows you to set very low timeouts, e.g. < 1 minute, which can be done in error.

Setting timeout to 25 hours The current documentation
image image

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions