Skip to content

Update Kubernetes client library #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csweichel opened this issue Jan 7, 2021 · 4 comments
Closed

Update Kubernetes client library #2689

csweichel opened this issue Jan 7, 2021 · 4 comments
Assignees
Labels
component: ws-manager component: ws-scheduler type: work item This issue pertains to something we have to do where the result is not code or a deployed feature
Milestone

Comments

@csweichel
Copy link
Contributor

csweichel commented Jan 7, 2021

We're still sitting on dependency of kubernetes/client-go version 1.15. We should update to at least 1.17, better yet 1.19.

Use https://github.com/gitpod-io/gitpod/blob/master/components/common-go/go-get-kubernetes.sh to update followed by leeway link.

This is directly influenced by #2657

@geropl
Copy link
Member

geropl commented Jan 7, 2021

Note: The move the 1.19 seems to be not very hard, as Gitpod mainly runs when switching to that master version, except one new field: Pod.PodSpec.PodSecurityContext.SeccompProfile

@csweichel csweichel added the type: work item This issue pertains to something we have to do where the result is not code or a deployed feature label Jan 8, 2021
@csweichel csweichel self-assigned this Jan 8, 2021
@corneliusludmann
Copy link
Contributor

@csweichel Have you done something on this issue yet? I had noticed the other day that Gitpod does not work with k3s version v1.20.0+k3s2. After community members stumbled upon this as well, I took a look. It turns out that Gitpod does not work with Kubernetes 1.20 because the Kubernetes go client library needs to be updated. To verify this, I updated the client library to version v0.20.1 (1.20) (see 4f884be / clu/gitpod-k3s-v1-20—quick and dirty change, some places need probably be improved). With this change, Gitpod runs on Kubernetes 1.20 / latest k3s and our GCP dev-preview runs as well (at least workspaces start).

@csweichel
Copy link
Contributor Author

@corneliusludmann did you use go-get-kubernetes.sh and leeway link or manually replace stuff in the go.mods?

@corneliusludmann
Copy link
Contributor

I used go-get-kubernetes.sh and leeway link.

csweichel pushed a commit that referenced this issue Jan 11, 2021
pavan-tri pushed a commit to trilogy-group/gitpod that referenced this issue Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ws-manager component: ws-scheduler type: work item This issue pertains to something we have to do where the result is not code or a deployed feature
Projects
None yet
Development

No branches or pull requests

3 participants