[dashboard] Close modals when typing esc key and clicking outside the modal #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

gtsiolis opened this issue Mar 18, 2021 · 0 comments

Assignees

Labels

component: dashboard roadmap item: new dashboard user experience

Contributor

gtsiolis commented Mar 18, 2021

Proposal

On the new dashboard, modals close when clicking outside the modal area. However:

The modal also closes when clickin within the modal area.
Typing escape (ESC) key does not close the modal.

gtsiolis added user experience component: dashboard labels

svenefftinge added this to the March 2021 milestone

svenefftinge added the roadmap item: new dashboard label

svenefftinge mentioned this issue

[dashboard] misc dashboard improvements #3496

Merged

svenefftinge self-assigned this

svenefftinge closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment