Skip to content

Implement /install-github-app flow #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svenefftinge opened this issue Apr 1, 2021 · 2 comments
Closed

Implement /install-github-app flow #3702

svenefftinge opened this issue Apr 1, 2021 · 2 comments

Comments

@svenefftinge
Copy link
Member

svenefftinge commented Apr 1, 2021

We need to implement the flow for installing the Github app.

Currently it is:

  1. https://github.com/apps/gitpod-io (click configure)
  2. /install-github-app

Screenshot 2021-04-01 at 12 28 42

  1. Agree on github
  2. confirmation

Screenshot 2021-04-01 at 12 28 54

Designs

Install Warning Success Error
image image image image

See also design specs.

@svenefftinge
Copy link
Member Author

There are currently three different outcomes:

<Dialog open={this.state.showDialog === 'cancel'}>
                    <DialogTitle>Cancel installation?</DialogTitle>
                    <DialogContent>
                        <DialogContentText>Canceling the installation here just prevents Gitpod from reacting to the events it receives from GitHub.
                        To fully undo the installation, please uninstall the <a href={`https://github.com/settings/installations/${this.installationId}`} target="_blank" rel="noopener noreferrer">Gitpod app in GitHub</a>.</DialogContentText>
                    </DialogContent>
                    <DialogActions>
                        <Button onClick={() => this.setState({ showDialog: 'none' })} variant="outlined" color="primary">Abort</Button>
                        <Button onClick={() => window.location.href = `https://github.com/settings/installations/${this.installationId}`} variant="outlined" color="secondary" autoFocus>Ok</Button>
                    </DialogActions>
                </Dialog>
                <Dialog open={this.state.showDialog === 'errorWhenReg'}>
                    <DialogTitle>Error while installing the app</DialogTitle>
                    <DialogContent>
                        <DialogContentText>Could not register the app with Gitpod - there seems to be a network issue. Please try again in a moment.</DialogContentText>
                    </DialogContent>
                    <DialogActions>
                        <Button onClick={() => this.setState({ showDialog: 'none' })} variant="outlined" color="secondary" autoFocus>Ok</Button>
                    </DialogActions>
                </Dialog>
                <Dialog open={this.state.showDialog === 'done'}>
                    <DialogTitle>Installation successful</DialogTitle>
                    <DialogContent>
                        <DialogContentText>The GitHub app was installed successfully. Have a look at the <a href="https://www.gitpod.io/docs/prebuilds/" target="_blank" rel="noopener">documentation</a> to find out how to configure it.</DialogContentText>
                    </DialogContent>
                    <DialogActions>
                        <Button onClick={() => window.location.href = thisUrl.asDashboard().toString()} variant="outlined" color="secondary" autoFocus>Ok</Button>
                    </DialogActions>
                </Dialog>

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 1, 2021

Resolved in #3704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants