[dashboard] github app installation #3704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
sefftinge/implement-install-github-3702
branch
6 times, most recently
from
12f11c0 to
bdb4f3e
Compare
TODO: Remove changes in
|
|
fixes ##3702 |
svenefftinge
commented
Apr 1, 2021
| @@ -1205,7 +1205,7 @@ export class GitpodServerImpl<Client extends GitpodClient, Server extends Gitpod | |||
| const user = this.checkAndBlockUser(); | |||
|
|
|||
| if (!this.env.githubAppEnabled) { | |||
| throw new ResponseError(ErrorCodes.NOT_FOUND, 'User is not authenticated. Please login.'); | |||
| throw new ResponseError(ErrorCodes.NOT_FOUND, 'No GitHub enabled for this installation. Please talk to your administrator.'); | |||
There was a problem hiding this comment.
Should be 'No GitHub app enabled ....'
svenefftinge
force-pushed
the
sefftinge/implement-install-github-3702
branch
from
bdb4f3e to
2250b76
Compare
svenefftinge
force-pushed
the
sefftinge/implement-install-github-3702
branch
from
2250b76 to
55b137c
Compare
gtsiolis
reviewed
Apr 1, 2021
| <span className="text-gray-500">This action will also allow Gitpod to access private repositories. You can edit git provider permissions later in user settings.</span> | ||
| </div> | ||
| <div className="mt-6"> | ||
| <button className="secondary">Cancel</button> |
There was a problem hiding this comment.
issue: This went through with no action. We could potentially remove the button all together. /cc @csweichel @svenefftinge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to Test