[dashboard] opening a context from the stopping/stopped screen does not work

[akosyakov]

Bug description

See below.

Steps to reproduce

See below.

Expected behavior

No response

Example repository

No response

[jankeromnes]

Oh, is that because the link is inside the iframe? 👀

In that case, a potential fix could be to handle the link click with a onClick postMessage based redirect.

[akosyakov]

We used to have code which will send a message to the top window here:

gitpod/components/supervisor/frontend/src/shared/loading-frame.ts

Lines 14 to 21 in 58a1436

	const serverOrigin = startUrl.url.origin;
	const relocateListener = (event: MessageEvent) => {
	if (event.origin === serverOrigin && event.data.type == 'relocate' && event.data.url) {
	window.removeEventListener('message', relocateListener);
	window.location.href = event.data.url;
	}
	};
	window.addEventListener('message', relocateListener, false);

i.e. any link from iframe should post a message to the top window instead of directly changing window location

[jankeromnes]

Indeed, the code is still there:

gitpod/components/dashboard/src/start/StartWorkspace.tsx

Lines 156 to 162 in aaf5f33

	redirectTo(url: string) {
	if (this.runsInIFrame()) {
	window.parent.postMessage({ type: 'relocate', url }, '*');
	} else {
	window.location.href = url;
	}
	}

I'm hesitating between a "sophisticated" fix (<a href="javascript:void(0)" onClick={()=>this.redirectTo('...') />, doesn't support Cmd+Click) and a "cheap" fix (<a href="..." target="_blank" />, doesn't support Click). Any preference?

[jankeromnes]

Oh, target="_parent" looks promising: https://stackoverflow.com/a/19325592/3461173