Skip to content

[Dashboard] Implement /select-account #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svenefftinge opened this issue Apr 6, 2021 · 4 comments · Fixed by #3897
Closed

[Dashboard] Implement /select-account #3754

svenefftinge opened this issue Apr 6, 2021 · 4 comments · Fixed by #3897
Assignees
Labels
aspect: authentication This is a broad, abstract, and almost impractical category that we have yet to sort out. component: dashboard roadmap item: new dashboard

Comments

@svenefftinge
Copy link
Member

svenefftinge commented Apr 6, 2021

  1. First of, ensure you have two accounts with distinct provider connections, e.g. one with GitHub and one with GitLab.
  2. Log in with user A.
  3. Go to Integerations, try to connect with second provider (which is connected to user B)

You end up on an empty /select-account page.

Designs

Modal Modal (Spacing)
image image

See also design specs.

@AlexTugarev
Copy link
Member

@gtsiolis is this design spec still valid? #3072

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 6, 2021

@AlexTugarev Oh, specs in #3072 are obsolete but I can add them within the next hour if needed.

To allow some head start, this page could use the following patterns:

  1. A modal.
  2. Two list entries, as seen in Existing Workspaces specs in [Dashboard] Workspace Start Page #3301, with all the needed accout information on each entry.
  3. Two action buttons as seen in the existing page.

@AlexTugarev
Copy link
Member

I can add them within the next hour if needed.

I think this would be very helpful.

@gtsiolis gtsiolis added this to the March 2021 milestone Apr 6, 2021
@gtsiolis gtsiolis added aspect: authentication This is a broad, abstract, and almost impractical category that we have yet to sort out. roadmap item: new dashboard labels Apr 6, 2021
@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 6, 2021

@AlexTugarev I've added the design specs for this in the description above but wanted to provide also an alterative design that would reuse existing patterns and components in case this could help us implement this faster.

Proposal A Proposal B
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: authentication This is a broad, abstract, and almost impractical category that we have yet to sort out. component: dashboard roadmap item: new dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants