Add Select Account Modal #3897
Merged
Add Select Account Modal #3897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
changed the title
AlexTugarev
force-pushed
the
at/select-accout
branch
4 times, most recently
from
5e6e0ed to
60e75fd
Compare
AlexTugarev
force-pushed
the
at/select-accout
branch
2 times, most recently
from
ccb30a0 to
3df3bdf
Compare
|
Let's see what we have here! 👀 |
gtsiolis
approved these changes
Apr 13, 2021
| <div className="mt-4 flex rounded-md w-full bg-gray-200 p-4 mx-auto"> | ||
| <img className="w-4 h-4 m-1 ml-2 mr-4" src={info} /> | ||
| <span> | ||
| Disconnect a provider in one of you accounts, if you like to continue with the other account. |
There was a problem hiding this comment.
question: WDYT of the following? Alternatively, we could split the following into two alert components, one for information (gray) and one for warning (red).
Suggested change
| Disconnect a provider in one of you accounts, if you like to continue with the other account. | |
| This will disconnect the non-selected account and delete all its associated workspaces data and user settings like environment variables. To continue using the other account, go user settings and disconnect the existing provider connection. |
| } else { | ||
| continueWithCurrentAccount(); | ||
| } | ||
| }}>Continue</button> |
There was a problem hiding this comment.
question: Shall we also offer a secondary option to go back to user settings, Integrations?
There was a problem hiding this comment.
- in case we're seeing this on the /integrations page, the continue with current basically means stay here ✅
- in case we're seeing this on creation of workspaces, then it's translated to visiting /integrations ✅
please verify
There was a problem hiding this comment.
Sounds like a good MVC. Let's do it.
AlexTugarev
force-pushed
the
at/select-accout
branch
2 times, most recently
from
0a58495 to
312837a
Compare
Signed-off-by: Alex Tugarev <[email protected]>
AlexTugarev
force-pushed
the
at/select-accout
branch
from
312837a to
47cf247
Compare
|
@AlexTugarev let me know if you need another review round for this one! 🏓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3754