Don't make `gp` rely on PATH to look up `code`

[pattacini]

This request originates from a community post, where I described my use case foreseeing the possibility to launch a purposely installed version of code within a VNC desktop as in the screenshot below.

The point is that to this end I had to shadow in the PATH the version of code installed by the Gitpod layer. The latter causes headaches when the VS Code UI is selected in Gitpod: for example, gp open <filename> clearly no longer works.

@akosyakov suggested that this could be solved by preventing gp from relying on PATH to look up code.

[akosyakov]

Here

gitpod/components/ide/code/leeway.Dockerfile

Lines 63 to 68 in 7d934f6

	ENV GITPOD_ENV_SET_EDITOR code
	ENV GITPOD_ENV_SET_VISUAL "$GITPOD_ENV_SET_EDITOR"
	ENV GITPOD_ENV_SET_GP_OPEN_EDITOR "$GITPOD_ENV_SET_EDITOR"
	ENV GITPOD_ENV_SET_GIT_EDITOR "$GITPOD_ENV_SET_EDITOR --wait"
	ENV GITPOD_ENV_SET_GP_PREVIEW_BROWSER "code --command gitpod.api.preview"
	ENV GITPOD_ENV_SET_GP_EXTERNAL_BROWSER "code --open-external"

we should replace code with /ide/bin/code. PRs are welcomed!

[pattacini]

PR opened in #3846.

[akosyakov]

fixed by #3846 we are going to deploy it tomorrow morning

[pattacini]

Hi @akosyakov

I'm still getting /ide/bin/code as the output of which code on a fresh workspace, meaning that it's still in the PATH.

Do I need to wait longer for the deployment?

[akosyakov]

We did not fix shadowing of code, only you can do it, but gp open should delegate to Gitpod Code CLI. Does gp open work for you?

[pattacini]

Ok then! Let me try: I have to generate my docker images again.

[pattacini]

It works like a charm 👍🏻
Thanks again!