Skip to content

Filter dropdown swaps back to active on every page load #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apolopena opened this issue Apr 9, 2021 · 4 comments
Closed

Filter dropdown swaps back to active on every page load #3875

apolopena opened this issue Apr 9, 2021 · 4 comments
Labels
component: dashboard meta: stale This issue/PR is stale and will be closed soon meta: 🤔 reporter-feedback-needed cannot process further since we need more info from the reporter

Comments

@apolopena
Copy link

apolopena commented Apr 9, 2021

Bug description

In the New workspace dashboard:
Two items to the left of the workspace button is the filter dropdown. I understand why the filter drowdown defaults to 'active' and that is fine however it is too agressive to switch that status back to 'active' on every page load. Perhaps a 1 hour cookie that keep this dropdown on the choice the user last left it is in order?

The perfect example of this being a bug-like hinderance or leaving the user feeling that their descisions have been 'hijacked', is in the case of them deleting a series of non active workspaces. This flow is described below in the steps to reproduce section

Steps to reproduce

In your workspace dashboard with multiple workspaces active and not active. Go about deleting some of your unused workspaces:

  1. Change dropdown filter to 'All'
  2. Click a workspaces hamburger
  3. Click Delete
  4. Acknowledge delete
  5. Page reloads
  6. The filter dropdown is reset to 'Active'
  7. The workspaces the user was trying to delete have disapeared
  8. The user now how to repeat 5 steps to delete a single workspace.

Expected behavior

A user should have the option to make their choices in the UI 'stick', even if this is for a limited time.

Example repository

Any

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 9, 2021

Hey @apolopena! I cannot reproduce step 4. Page does not reload and the filter remains on All. Is this related to #3876?

@gtsiolis gtsiolis added component: dashboard meta: 🤔 reporter-feedback-needed cannot process further since we need more info from the reporter labels Apr 9, 2021
@apolopena
Copy link
Author

apolopena commented Apr 9, 2021

@gtsiolis
No this issue is unrelated to #3876.
I will go over my reproduction steps again and see what happens.

@apolopena apolopena changed the title New Workspace Dashboard: filter dropdown swaps back to active on every page load Filter dropdown swaps back to active on every page load Apr 9, 2021
@apolopena
Copy link
Author

@gstiolis
After going through my reproduction steps again it turns out this issue does indeed appear to be releated to #3876. This is odd because I did not get the same results the second time I reproduced this issue. The only difference in the reproductions steps I took might be that the first time around I was deleting allready timed out workspaces and the second time around I was deleting workspaces that I had stopped manually.

This second time around, all stopped workspaces were deleted all at once and the page reloaded but the filter dropdown stayed on All.

@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 8, 2021
@stale stale bot closed this as completed Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: stale This issue/PR is stale and will be closed soon meta: 🤔 reporter-feedback-needed cannot process further since we need more info from the reporter
Projects
None yet
Development

No branches or pull requests

2 participants